[cp-patches] RFC: proposed additions to MenuBarPeer and MenuPeer interfaces

[Thomas Fitzsimmons]

Hi,

I tried compiling the GTK peers with Sun's javac.  It failed because
these two methods were missing.  Obviously Sun's peer interfaces must
include them.  I propose we add them to our peer interfaces as well.
What do people think of this idea?

Tom

2005-08-12  Thomas Fitzsimmons  <address@hidden>

        * gnu/java/awt/peer/gtk/GtkMenuBarPeer.java (addMenu(Menu)): New
        method.
        * gnu/java/awt/peer/gtk/GtkMenuPeer.java (addSeparator): Likewise.
        * java/awt/peer/MenuBarPeer.java (addMenu): New method
        declaration.
        * java/awt/peer/MenuPeer.java (addSeparator): New method
        declaration.

Index: ChangeLog
===================================================================
RCS file: /cvsroot/classpath/classpath/ChangeLog,v
retrieving revision 1.4408
diff -u -r1.4408 ChangeLog
--- ChangeLog   12 Aug 2005 22:49:41 -0000      1.4408
+++ ChangeLog   12 Aug 2005 23:07:11 -0000
@@ -1,5 +1,15 @@
 2005-08-12  Thomas Fitzsimmons  <address@hidden>
 
+       * gnu/java/awt/peer/gtk/GtkMenuBarPeer.java (addMenu(Menu)): New
+       method.
+       * gnu/java/awt/peer/gtk/GtkMenuPeer.java (addSeparator): Likewise.
+       * java/awt/peer/MenuBarPeer.java (addMenu): New method
+       declaration.
+       * java/awt/peer/MenuPeer.java (addSeparator): New method
+       declaration.
+
+2005-08-12  Thomas Fitzsimmons  <address@hidden>
+
        * gnu/java/awt/peer/gtk/GtkButtonPeer.java,
        native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c
        (gtkWidgetGetPreferredDimensions): New method.
Index: gnu/java/awt/peer/gtk/GtkMenuBarPeer.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/GtkMenuBarPeer.java,v
retrieving revision 1.10
diff -u -r1.10 GtkMenuBarPeer.java
--- gnu/java/awt/peer/gtk/GtkMenuBarPeer.java   2 Jul 2005 20:32:12 -0000       
1.10
+++ gnu/java/awt/peer/gtk/GtkMenuBarPeer.java   12 Aug 2005 23:07:11 -0000
@@ -77,4 +77,9 @@
   }
 
   public native void delMenu(int index);
+
+  public void addMenu (Menu m)
+  {
+    // FIXME: implement
+  }
 }
Index: gnu/java/awt/peer/gtk/GtkMenuPeer.java
===================================================================
RCS file: /cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/GtkMenuPeer.java,v
retrieving revision 1.10
diff -u -r1.10 GtkMenuPeer.java
--- gnu/java/awt/peer/gtk/GtkMenuPeer.java      2 Jul 2005 20:32:12 -0000       
1.10
+++ gnu/java/awt/peer/gtk/GtkMenuPeer.java      12 Aug 2005 23:07:11 -0000
@@ -100,4 +100,9 @@
   }
 
   public native void delItem(int index);
+
+  public void addSeparator()
+  {
+    // FIXME: implement
+  }
 }
Index: java/awt/peer/MenuBarPeer.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/peer/MenuBarPeer.java,v
retrieving revision 1.10
diff -u -r1.10 MenuBarPeer.java
--- java/awt/peer/MenuBarPeer.java      2 Jul 2005 20:32:36 -0000       1.10
+++ java/awt/peer/MenuBarPeer.java      12 Aug 2005 23:07:11 -0000
@@ -42,6 +42,7 @@
 
 public interface MenuBarPeer extends MenuComponentPeer
 {
+  void addMenu(Menu m);
   void addHelpMenu(Menu menu);
   void delMenu(int index);
 } // interface MenuBarPeer 
Index: java/awt/peer/MenuPeer.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/peer/MenuPeer.java,v
retrieving revision 1.12
diff -u -r1.12 MenuPeer.java
--- java/awt/peer/MenuPeer.java 2 Jul 2005 20:32:36 -0000       1.12
+++ java/awt/peer/MenuPeer.java 12 Aug 2005 23:07:11 -0000
@@ -43,6 +43,7 @@
 public interface MenuPeer extends MenuItemPeer
 {
   void addItem (MenuItem item);
+  void addSeparator ();
   void delItem (int index);
 }