[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] [RFA/JDWP] Frame.java
From: |
Aaron Luchko |
Subject: |
Re: [cp-patches] [RFA/JDWP] Frame.java |
Date: |
Fri, 12 Aug 2005 15:23:28 -0400 |
On Fri, 2005-08-12 at 15:11 -0400, Bryce McKinlay wrote:
> Aaron Luchko wrote:
>
> >On Fri, 2005-08-12 at 14:11 -0400, Aaron Luchko wrote:
> >
> >
> >>This class defines an interface to the VM to represent a Frame (as well
> >>as changes the imports for the couple command sets that use it)
> >>
> >>
> >
> >Ok I talked to Bryce and looked at Keiths email and think I have done
> >this the correct way this time.
> >
> >Aaron
> >ChangeLog
> >2005-08-12 Aaron Luchko <address@hidden>
> >
> > * vm/reference/gnu/classpath/jdwp/Frame.java: Implemented
> > reference implementation of interface to VM for JDWP frame
> > management.
> > * gnu/classpath/jdwp/processor/StackFrameCommandSet.java:
> > updated import
> > * gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java:
> > updated import
> > (executeFrames): changed getLoc() to getLocation()
> >
> >
>
> Aaron,
>
> Just a couple of nits:
>
> 1. Please make sure that each ChangeLog entry is a full sentence, ie:
> capital letter and ".".
Sure
> 2. You may want to call the "Frame" class "VMFrame", in order to be
> consistent with other "reference" classes which are meant to be
> implemented by the VM?
Done
>
> Also, this comment (and the corresponding one in getObject()) seems a
> little odd to me:
>
> >+public class Frame
> >+{
> >+ // The object this frame resides in
> >+ private Object obj;
> >
>
> Its strange to me to think of frames "residing in" objects. Rather,
> some, but not all, frames are associated with a particular object (ie
> "this").
Cool, fixed
>
> Otherwise, this is OK.
thanks for the quick response.
Committed this patch to HEAD
Aaron
ChangeLog
2005-08-12 Aaron Luchko <address@hidden>
* vm/reference/gnu/classpath/jdwp/VMFrame.java: Implemented
reference implementation of interface to VM for JDWP frame
management.
* gnu/classpath/jdwp/processor/StackFrameCommandSet.java:
Updated import.
(executeGetValues): Use VMFrame instead of Frame.
(executeSetValues): Use VMFrame instead of Frame.
(executeThisObject): Use VMFrame instead of Frame.
* gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java:
Updated import.
(executeFrames): Changed getLoc() to getLocation() and use
VMFrame instead of Frame.
jdwpVMFrame.patch
Description: Text Data