Re: [cp-patches] FYI: JTable cell editing implemented and committed

[Roman Kennke]

Hi tony,

> A demo will be added shortly, for now I am attaching a small test app
> that you can use to test the editing functionality.  With a table cell
> selected, pressing F2 starts editing and then pressing ENTER stops
> editing.

Are these keybindings the same in the JDK?

> 2 notes:
> - the test app appears to draw incorrectly at the top, this is due to
> some trouble in BasicViewportUI

So my fix from last week wasn't perfect. I'll have a look at it when I
find some time.

> - if you edit more than one cell, you will notice that text from
> previously edited cells appears in the cell you are currently editing,
> this is due to bugs in JTextField/JTextComponent


Ah yes. I will also look at this, I am working on javax.swing.text
anyway and already have lots of patches on my HD. Possible that it's
already fixed here...

Thank you for this work. Very nice.

The obligatory minor nitpicks:
- Inline comments should be sentences starting with capital letter and
ending with a point.
- Try to API-comment all new methods (and the existing ones when you see
an uncommented method), ideally also the private and package private
methods.

/Roman