Re: [cp-patches] [RFC/JDWP] ClassLoaderReferenceCommandSet

[Aaron Luchko]

On Mon, 2005-08-08 at 17:36 -0400, Aaron Luchko wrote:
> Here's two different proposals for the ClassLoaderRefererenceCommandSet
> http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_ClassLoaderReference
> 
> There's only a single command which asks for a list of every class the
> ClassLoader has been requested to load. The first way to do this is just
> use a hook in the vm. I don't know enough with how ClassLoaders are
> handled within the vm to know how easy this would be to implement.
> 
> The second method involves a patch to ClassLoader which adds a single
> variable loadRequests which will store every Class that is requested to
> be loaded.
> 
> The patch has the advantages of being vm-agnostic and avoiding yet
> another hook into the virtual machine.
> 
> On the downside we're putting what seems a useless variable in
> ClassLoader and we may induce a small performance penalty (although this
> could easily be present in the VM-hook as well).
> 
> The ClassLoader patch doesn't need to go in until we're further along if
> we use it.

Thanks for all the feedback, I've committed version 1 of the patch.

Aaron

ChangeLog       
    * gnu/classpath/jdwp/processor/ClassLoaderReferenceCommandSet.java: 
    Implemented the ClassLoaderReference CommandSet.