classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: java/io/ObjectInputStream.java clean up


From: Jeroen Frijters
Subject: [cp-patches] FYI: java/io/ObjectInputStream.java clean up
Date: Sun, 7 Aug 2005 14:27:40 +0200

Hi,

I committed the attached patch to pass or initialize causes for all
exceptions and to remove some bogus code from readClassDescriptor.

I also added a comment to readFields.GetField.getField that it should be
rewritten, the current code is *totally* incomprehensible. (Including
the anti-pattern "return from finally".)

Regards,
Jeroen

2005-08-06  Jeroen Frijters  <address@hidden>

        * java/io/ObjectInputStream.java
        (readClassDescriptor): Removed bogus handling of primitive
types.
        (readFields.GetField.defaulted): Pass cause to exception.
        (readFields.GetField.getField): Pass cause to exception.
        (newObject, callReadMethod): Call initCause on exception.

Attachment: ObjectInputStream.patch.txt
Description: ObjectInputStream.patch.txt


reply via email to

[Prev in Thread] Current Thread [Next in Thread]