[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[cp-patches] Re: [RFA/JDWP] JdwpConnection cleanup
From: |
Keith Seitz |
Subject: |
[cp-patches] Re: [RFA/JDWP] JdwpConnection cleanup |
Date: |
Thu, 30 Jun 2005 09:24:48 -0700 |
On Mon, 2005-06-27 at 17:23 -0400, Bryce McKinlay wrote:
> Yes, this looks better.
[snip]
> However, there is still a bit too much copying going on - couldn't
> JdwpPacket.toBytes() write directly to the stream, instead of creating
> another temporary byte[]? That can be fixed in another patch, though.
> I think I liked the old sendPacket() name better, but maybe thats just me :)
I've addressed these concerns in the following two patches. Patch #1
contains the original changes submitted. Patch #2 addresses the
JdwpPacket.toBytes issue.
?
Keith
ChangeLog #1
2005-06-30 Keith Seitz <address@hidden>
* gnu/classpath/jdwp/transport/JdwpConnection.java (sendEvent): New
method.
(_bytes): New member.
(_doStream): New member.
(JdwpConnection): Initialize new members.
ChangeLog #2
2005-06-30 Keith Seitz <address@hidden>
* gnu/classpath/jdwp/transport/JdwpPacket.java (write): New method.
(myWrite): New abstract method.
(toBytes): Remove.
(myToBytes): Remove.
* gnu/classpath/jdwp/transport/JdwpReplyPacket.java (myWrite): New
method.
* gnu/classpath/jdwp/transport/JdwpCommandPacket.java (myWrite): New
method.
* gnu/classpath/jdwp/transport/JdwpConnection.java (sendPacket): Use
JdwpPacket.write instead of JdwpPacket.toBytes.
jdwp-connection-1.patch
Description: Text Data
jdwp-connection-2.patch
Description: Text Data