Re: [cp-patches] RFC: Some iconv provider (build) fixes

[Ito Kazumitsu]

Hi,

From: Mark Wielaard <address@hidden>
Subject: [cp-patches] RFC: Some iconv provider (build) fixes
Date: Sun, 24 Apr 2005 23:49:29 +0200

> Here are some fixes to make the iconv provider build on more systems
> (hopefully), get rid of an obnoxious gcc warning, be a little bit more
> efficient and fix for a memory leak. Since I only have access to
> GNU/Linux systems I am looking for people wanting to try this out on
> some other system like darwin, freebsd or solaris.

I tried your fixes on

   OS: FreeBSD 5.3-RELEASE
   VM: Kaffe (CVS 2005-04-25  Ito Kazumitsu <address@hidden>)

and it worked without problem.

>         * iconv.m4: New file.
>         * configure.ac: Use AM_ICONV.
>         * native/jni/java-nio/Makefile.am (libjavanio_la_LIBADD):
>         Add LTLIBICONV.

I ignored these files because kaffe's build procedure takes care of
these.

>         * native/jni/java-nio/gnu_java_nio_charset_iconv_IconvDecoder.c:
>         * native/jni/java-nio/gnu_java_nio_charset_iconv_IconvEncoder.c:
>         * gnu/java/nio/charset/iconv/IconvDecoder.java (dispose): Renamed.
>         * gnu/java/nio/charset/iconv/IconvEncoder.java (dispose): Renamed.

I applied these patches.