Re: [cp-patches] Patch: RFA: jni.h re-merge

[Mark Wielaard]

Hi,

On Fri, 2005-04-22 at 18:35 -0600, Tom Tromey wrote:
> I'm not checking this in yet, but I plan to if I don't hear any
> objections.  I believe this change requires a change to VMs.

If runtimes don't come with their own jni.h for building their own
internal jni implementation. I believe most runtimes/compilers actually
have their own version for that.

> I changed the name of a preprocessor macro to be more
> "classpath-like".  In particular I changed
> _JNI_VM_INTERNAL_TYPES_DEFINED to _CLASSPATH_VM_JNI_TYPES_DEFINED.
> 
> I also added a couple more jni.h-tweaking symbols with a similar
> naming scheme.  These are documented in vmintegration.texinfo.  Both
> are used by libgcj.

Could you explicitly add that you only need to define any of these when
compiling a jni implementation for your runtime/compiler based on GNU
Classpath? And please add a little note about this to the NEWS file
(just point to the updated Integration Guide).

> Let me know what you think,

I think this is fine.

Could you either check it in before the end of Monday so we have it in
for the next release (test-cycle) or wait till after the release (end of
the week)?

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part