classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] PATCH: fix PrivateKeyUsagePeriod parsing


From: Casey Marshall
Subject: Re: [cp-patches] PATCH: fix PrivateKeyUsagePeriod parsing
Date: Thu, 21 Apr 2005 21:22:05 -0700
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)

>>>>> "Michael" == Michael Koch <address@hidden> writes:

Michael> On Sun, Apr 17, 2005 at 07:51:51PM -0700, Casey Marshall wrote:
>> Hi list;
>> 
>> Tom Fitzsimmons pointed out a flaw in the X.509 parsing code that
>> handles the 'privateKeyUsagePeriod' extension, which is encoded as a
>> pair of two optional dates, but aren't tagged as such in ASN.1. So the
>> existing code naively tries to cast the result as a Date, which fails
>> because the type of the value field can't be determined at that point.
>> 
>> Ok to commit?

Michael> Sure, you are the expert for this.

Ok, thanks. Commited as:

2005-04-21  Casey Marshall  <address@hidden>

        * gnu/java/security/der/DERValue.java
        (getValueAs): new method.
        * gnu/java/security/x509/ext/PrivateKeyUsagePeriod.java
        (<init>): read both dates with 'DERValue.getValueAs', with
        'GENERALIZED_TIME' as the argument.

-- 
Casey Marshall || address@hidden

Attachment: pkup.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]