PING: Re: [cp-patches] RFC: Fix for "XXX" use in java.util.Currency

[Andrew John Hughes]

On Mon, 2005-03-28 at 01:41 +0100, Andrew John Hughes wrote:
> The attached patch allows examples such as the following:
> 
> NumberFormat.getCurrencyInstance(Locale.ENGLISH).getCurrency()
> 
> to succeed with the result of a Currency instance containing "XXX"
> rather than throwing a NullPointerException.  This is Sun's behaviour,
> which is made possible by allowing "XXX" to be supplied to
> Currency.getInstance(String).  This is something we have discussed
> before, which has lead to the introduction of the String version
> of this value in java.text.DecimalFormatSymbols (11 Jan - Fix for Bug #11545).
> 
> Should we allow this horrible design decision to creep into
> GNU Classpath?  Comments please.
> 
> Changelog:
> 
> 2005-03-28  Andrew John Hughes  <address@hidden>
> 
>       * java/text/DecimalFormatSymbols.java:
>       Added retrieval of "XXX" instance in place of null.
>       * java/util/Currency.java,
>       (Currency(String)): New constructor for the XXX special case.
>       (getInstance(String)): Allow special case of "XXX".
> 
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

Does anyone have any comments on this patch, posted March 28th?  Should
I commit it or not?

Thanks,
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
public class gcj extends Freedom implements Java { ... }

signature.asc
Description: This is a digitally signed message part