chicken-janitors
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-janitors] Re: #287: timezone fixes


From: Chicken Trac
Subject: [Chicken-janitors] Re: #287: timezone fixes
Date: Tue, 20 Jul 2010 02:09:01 -0000

#287: timezone fixes
----------------------------+-----------------------------------------------
 Reporter:  zbigniew        |       Owner:  felix   
     Type:  enhancement     |      Status:  accepted
 Priority:  minor           |   Milestone:  4.6.0   
Component:  core libraries  |     Version:  4.5.x   
 Keywords:                  |  
----------------------------+-----------------------------------------------

Comment(by zbigniew):

 Patch 0003 fixes an oversight in the polarity of tm_gmtoff when a struct
 tm is being copied in and out of a vector.  tm_gmtoff is seconds east of
 UTC, while our 10-element vector holds seconds west of UTC.  This is
 already handled in C_decode_seconds but not in the generic vector copy
 code.

 {{{
 (time->string (seconds->local-time) "%z")   ;=> "+0500"         ; before
 patch
 (time->string (seconds->local-time) "%z")   ;=> "-0500"         ; after
 }}}

 strftime handling of %Z and %z is actually pretty iffy regardless;
 typically %Z will ignore the timezone offset you provide and just use your
 local timezone, and %z doesn't even correct for DST on OS X.  There's
 nothing we can do about this.  However, I fixed the bug anyway because it
 is a genuine issue in tm_gmtoff handling.

-- 
Ticket URL: <http://www.irp.oist.jp/trac/chicken/ticket/287#comment:4>
Chicken Scheme <http://www.call-with-current-continuation.org/>
Chicken Scheme is a compiler for the Scheme programming language.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]