Re: [Chicken-hackers] [PATCH] Use arc4random_buf on FreeBSD/DragonFly

[Tobias Kortkamp]

On Fri, Sep 7, 2018, at 17:13, address@hidden wrote:
> > * address@hidden <address@hidden> [180906 12:27]:
> > > Should be self-explaining...
> > 
> > I would delay this patch. I did look up FreeBSD's code base and it
> > seems that they have importet OpenBSD's version 18 days ago, according
> > to https://github.com/freebsd/freebsd/blob/master/lib/libc/gen/arc4random.c
> > 
> > The old version does not use a save random number generator and
> > using the old method is better in that case.  Same goes for DragonFly.
> > 
> 
> Well, we can just leave things as they are for the moment.

I'm not sure I understand what the concerns are, but
at least for FreeBSD adding a __FreeBSD_version check might be the
way to go if the older arc4random is not ok to use.

Per the FreeBSD Porter's Handbook OpenBSD's safer arc4random
was adopted in 1200079 [1] so the check could be changed to

(defined(__FreeBSD__) && __FreeBSD_version >= 1200079)

[1] 
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/versions.html#freebsd-versions-table-12