[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Chicken-hackers] [PATCH] Fix for Windows quoting issues (fixes #1515)
From: |
Peter Bex |
Subject: |
[Chicken-hackers] [PATCH] Fix for Windows quoting issues (fixes #1515) |
Date: |
Sat, 1 Sep 2018 20:39:33 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Hi all,
Here's a patch for #1515. It turns out to be quite invasive because the
quotation stuff was completely messed up. Even on *nix, chicken-install
didn't work when CHICKEN was installed to a PREFIX path with spaces in it!
I tested this on *nix with PREFIX "~/chicken 5 with spaces"
and on Windows with PREFIX "C:/c5+test" like Kris tested it.
After fixing all the quoting issues, I finally ran into this weirdness
when running the tests:
https://stackoverflow.com/questions/9964865/c-system-not-working-when-there-are-spaces-in-two-different-parameters#9965141
Note that this only holds for system(), it does not seem to be necessary
in batch files.
I can't quite find the words to express how I felt about this when I
read it. Just Windows being Windows, as usual, I guess...
The second patch fixes a type declaration issue I found while working
on the first patch: "qs" accepts a second optional argument, but the
types database only knew about the first argument.
Cheers,
Peter
0001-Fix-quotation-in-scripts-generated-by-chicken-instal.patch
Description: Text Data
0002-Fix-type-declaration-for-qs-procedure.patch
Description: Text Data
signature.asc
Description: PGP signature
- [Chicken-hackers] [PATCH] Fix for Windows quoting issues (fixes #1515),
Peter Bex <=