[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH][5] FQN woes

From: lemonboy
Subject: Re: [Chicken-hackers] [PATCH][5] FQN woes
Date: Mon, 15 May 2017 20:27:16 +0200

After some more testing I've got a revised and hopefully better patchset.

Please review with care,

On 10 May 2017 at 11:00, Evan Hanson <address@hidden> wrote:
> Hey Lemonboy,
> On 2017-05-09 16:20, lemonboy wrote:
>> since both `##sys#macro-environment` and `##sys#current-environment`
>> are alists whose keys are unqualified symbol names it doesn't make
>> sense to use `var` as lookup key since after the initial lookup of
>> `var0` against the environment we possibly get back a fully-qualified
>> symbol thus making the lookup fail.
> Good catch, thanks.
> Just repeating what I said on IRC: could you add a small test that
> checks for one of each of these warnings? There are already some tests
> that check the compiler's output, and even just adding the example you
> gave to one of those would be fine.
>> I don't know if the same treatment should be applied to the `keyword?`
>> test below, if it can be folded inside the `cond`
> Keywords are never bound in the environment so it doesn't matter, but if
> you want to use the same variable as is used in the other checks for
> consistency's sake, that makes sense to me. Pulling it up makes sense
> too.
> Cheers,
> Evan

Attachment: 0001-Small-code-cleanup-in-the-expander.patch
Description: Text Data

Attachment: 0002-Use-the-raw-variable-name-in-env-lookups-and-errors.patch
Description: Text Data

Attachment: 0003-Add-some-unit-tests.patch
Description: Text Data

Attachment: 0004-Keep-the-module-module-defined-syntax-list-updated.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]