chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH 0/1] Add _XOPEN_SOURCE feature test macro


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH 0/1] Add _XOPEN_SOURCE feature test macro
Date: Tue, 17 Jan 2017 21:50:54 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Jan 17, 2017 at 12:36:08PM +1300, Evan Hanson wrote:
> > Attached is a modified version of the patch which sets _XOPEN_SOURCE
> > to 700, which unlocks SUSv4 / POSIX.1-2008 support.  I've tested this
> > and an added benefit is that setting it to 700 also makes a warning
> > about "implicit declaration of function nanosleep()" go away on GNU
> > Hurd.
> 
> Looks good to me. That seems to be what's expected anyway, a value
> rather than just the definition.
> 
> > I've tested it on MingW, Cygwin, Hurd and Linux.
> 
> Linux, OpenBSD, MinGW-w64, Cygwin, MSYS2.
> 

Looks like FreeBSD doesn't like this one bit.  The Salmonella builds
have started to fail completely:
http://salmonella-freebsd-x86-64.call-cc.org/master/clang/freebsd/x86-64/2017/01/16/

Attached patch introduces a new knob to tune: C_USE_STD_FEATURE_MACROS,
which is currently unconditionally defined in all platform Makefiles,
except for BSD, where it's enabled for all but FreeBSD.  Apparently
they believe feature macros should not behave like they do on Linux,
whereas on NetBSD and OpenBSD it behaves the same.

I haven't tested a lot of platforms, but this shouldn't really change
anything except on FreeBSD anyway... (haha, famous last words)

Cheers,
Peter

Attachment: 0001-Do-not-use-feature-macros-on-FreeBSD.chicken-5.patch
Description: Text Data

Attachment: 0001-Do-not-use-feature-macros-on-FreeBSD.master.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]