Re: [Chicken-hackers] [PATCH] Make `define-constant` support singly-quoted symbols

[Evan Hanson]

On 2016-05-29 16:00, Peter Bex wrote:
> I think this fix is not the correct way to do it: it changes "val"
> from plain frizzle to (quote frizzle), causing "collapsable-literal?"
> to return #f (a list isn't collapsable).  This happens also when val
> is a fixnum, for example, so the first case in the cond is _never_
> matched, meaning the constant-table will stay empty.

Ah, good catch, thanks. I've applied your fix with the minor change of
using "##core#quote" rather than plain "quote" around the value, for the
rare cases when `define-constant` is used in an environment where
`quote` hasn't been imported.

Also applied to master.

Thanks for the review,

Evan

signature.asc
Description: PGP signature