chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH 1/2] Allow overriding of interpreter path f


From: Oleg Kolosov
Subject: Re: [Chicken-hackers] [PATCH 1/2] Allow overriding of interpreter path for POSIX tests
Date: Sat, 1 Aug 2015 17:26:00 +0300

> On Aug 1, 2015, at 16:42, Peter Bex <address@hidden> wrote:
> 
> On Fri, Jul 24, 2015 at 02:21:45AM +0300, Oleg Kolosov wrote:
>>> On Jul 24, 2015, at 02:16, Oleg Kolosov <address@hidden> wrote:
>>> 
>>> Hello.
>>> 
>>> I was cleaning my CHICKEN development branches and decided to contribute 
>>> few things.
>>> 
>>> This patch gets rid of hardcoded path to csi in posix tests - looks 
>>> harmless and used for out of tree build support, which I will submit at 
>>> some later time.
> 
> Can you elaborate on this?  As it stands, the patch does not make
> much sense to me; it is testing the CHICKEN we just built, which
> will _always_ live in the build dir.
> 

I've added test suite to my work in progress CMake base build system which is 
supposed to work with out of source builds. This will allow current and new 
systems to coexist. This patch facilitates that.

While working on Windows support I've also found various small things like more 
missing C_ prefixes, missing #ifdef HAVE_... around includes and such and 
decided to submit them separately starting from the most trivial ones.

But looks like with large time interval between patches it is confusing. I can 
submit everything at once when finish cleaning if it is easier to handle. 

— 
Regards, Oleg
Art-System




reply via email to

[Prev in Thread] Current Thread [Next in Thread]