chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] Fix solaris9 build for missing trunc, round, isinf


From: Christian Kellermann
Subject: Re: [Chicken-hackers] Fix solaris9 build for missing trunc, round, isinf math functions
Date: Sat, 20 Apr 2013 17:02:13 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

* felix winkelmann <address@hidden> [130420 16:56]:
> From: Michele La Monaca <address@hidden>
> Subject: [Chicken-hackers] Fix solaris9 build for missing trunc, round, isinf 
> math functions
> Date: Wed, 17 Apr 2013 23:48:19 +0200
> 
> > This patch fixes Solaris 9 compilation (suncc) which fails due to
> > missing C99 math functions.
> 
> Thanks - signed off and pushed.
> 
> (I have pushed before realizing that this needs another signoff. 
> On the other hand, this patch is straightforward, so to follow
> THE RULES,  perhaps someone can do another signoff?)

No, published patches are better not changed as they would require
either a merge by everyone that already has the old patch, or you
would force everyone to throw away that patch and take the other.

That's the tooling folks.

And your pushing the patch is OK, Michele is the only person we
know that can possibly test this, so who else should sign it off?

Cheers,

Christian

-- 
In the world, there is nothing more submissive and weak than
water. Yet for attacking that which is hard and strong, nothing can
surpass it. --- Lao Tzu



reply via email to

[Prev in Thread] Current Thread [Next in Thread]