Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

[Felix]

From: Florian Zumbiehl <address@hidden>
Subject: Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts
Date: Mon, 18 Mar 2013 11:50:46 +0100

> Hi,
> 
>> On Mar 17, 2013, at 1:58 AM, Florian Zumbiehl wrote:
>> 
>> >  If you cannot be sufficiently sure
>> > that your approach is correct to be willing to build a full fix on it
>> > without testing first, I would consider that a sign that the approach is
>> > too fragile to rely on, at least without a good reason.
>> 
>> I was hoping you would just confirm you are experiencing the same problem
>> before I spend more time on it.
> 
> So, you want me to verify that your patch does not help? I am slightly
> confused ...

Yes, that seems to be the case. I will try to help you:

This is what Jim wrote:

> Florian, please try the attached patch.  It simply inlines
> (fail), removing the context switch at 1), and also passes
> the return value of ##sys#update-errno to strerror, eliminating 2).

> Assuming this works, I can produce a patch to fix the rest
> of the ##sys#update-errno + signal-hook clauses in the same way,
> as this combination is unsafe with SRFI 18.

So, as I understand it, he asks to you to try out whether _his_ patch
works for you or not, since you reported that you were experiencing
problems that he, apparently, can not. The question whether his patch
works for you or not (by failing, reproducing the problems you
experienced) might help Jim to decide on whether he should put anymore
effort into this issue.


cheers,
felix