chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] do not merge results when conditional bran


From: Christian Kellermann
Subject: Re: [Chicken-hackers] [PATCH] do not merge results when conditional branches differ in the number of result values
Date: Mon, 14 Nov 2011 15:09:08 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

* felix winkelmann <address@hidden> [111114 14:38]:
> When, during flow-analysis, the branches of a conditional expression differ
> in the number of result-values, the types where incorrectly merged, defaulting
> to the union of both branch results and cutting off the longer result-value
> sequence. In a "call-with-values" invocation with two result values, the
> cutoff could produce a single-valued result, triggering an optimization
> rule for this case (which replaces invocations to "call-with-values", where
> the thunk is known to produce a single result, with a simpler code
> sequence). The change disables the merge in this case and simply treats
> the expression as having an unknown number of results, which will not
> trigger the optimization rule.
> 
> This patch fixes #680.

Yepà it does! ;)

Looks fine to me (well, ...) and I have pushed it.

Kind regards,

Christian

-- 
Who can (make) the muddy water (clear)? Let it be still, and it will
gradually become clear. Who can secure the condition of rest? Let
movement go on, and the condition of rest will gradually arise.
 -- Lao Tse. 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]