[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] add input- and output port types specifier
Re: [Chicken-hackers] [PATCH] add input- and output port types specifiers
Fri, 30 Sep 2011 13:11:51 +0200
* felix winkelmann <address@hidden> [110930 13:06]:
> From: Christian Kellermann <address@hidden>
> Subject: Re: [Chicken-hackers] [PATCH] add input- and output port types
> Date: Fri, 30 Sep 2011 12:57:47 +0200
> > * felix winkelmann <address@hidden> [110930 08:40]:
> >> From: Alan Post <address@hidden>
> >> Subject: Re: [Chicken-hackers] [PATCH] add input- and output port types
> >> specifiers
> >> Date: Thu, 29 Sep 2011 06:21:22 -0600
> > The following hunk has nothing to do with ports but it is not used so I
> > agree.
> > This has nothing to do with ports, what does it do?
> > Should this be part of the commit?
> It is just a small optimization, and I guessed it would be ok
> to add it here. If you prefer, I can submit a separate patch.
> > The rest looks good to me and does not break anything on my system.
> > I will push it if noone objects. With or without the above hunk as you like.
> Thanks. If you add the hunk, it would save me a few minutes of
> fiddling with git.
I am fine with this. I just get paranoid when I read something I
don't quite understand *and* the comitter hasn't told me about it
:) It just *might* be an oversight you know :)
Who can (make) the muddy water (clear)? Let it be still, and it will
gradually become clear. Who can secure the condition of rest? Let
movement go on, and the condition of rest will gradually arise.
-- Lao Tse.