[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] simplify typevar instantiation handling in
Re: [Chicken-hackers] [PATCH] simplify typevar instantiation handling in scrutinizer
Tue, 27 Sep 2011 08:10:48 +0200 (CEST)
From: Christian Kellermann <address@hidden>
Subject: Re: [Chicken-hackers] [PATCH] simplify typevar instantiation handling
Date: Mon, 26 Sep 2011 21:45:59 +0200
> * felix winkelmann <address@hidden> [110926 13:28]:
>> From: Felix <address@hidden>
>> Subject: [PATCH] simplify typevar instantiation handling in scrutinizer
>> Date: Mon, 26 Sep 2011 09:23:02 +0200 (CEST)
>> > Attached is a patch that simplifies the use of
>> > "over-all-instantiations" in the scrutinizer. Peter was of course
>> > right about the redundant matching at some call-sites of this
>> > procedure, which I boneheadedly refused to see.
>> > This patch also fixes a bug in the transformation of the internal
>> > node tree to s-expressions for the "##core#typecase" construct.
>> > Testcases have been added. The changes have been tested with the
>> > core test-suite and all core libraries and tools.
>> Please ignore the previous patch. This new one contains an additional
>> fix in "type<=?" (subtype checking).
> I cannot say I understand fully what you are doing here. But I could
> not find an obvious blunder in it. But then I would have said the
> same about the previous version I guess :)
> It did not break anything on my system so far, so I say: OK.
Thanks for reviewing it.