-
bugs
1255622203
27711
Every Time
HLA compliance error
1256118645
libHLA
HLAoctetPairLE and HLAoctetPairBE may be 32bits on unix
gotthardp
Public
3 - Normal
Closed
CVS
3.3.3
erk
Ready For Test
The OPLE and OPLE are currently stored in a wchar_t whose
size may 4 octets on unix.
see: http://en.wikipedia.org/wiki/Wide_character
from the standard
IEEE 1516.2, Section 4.12.3, Table 23�Basic data representation table
this is wrong those types should be encoded on 2 octets.
I discover this fact when adding test0 to
libHLA/TestHLAtypes.cc
I did checked the failing test code into CVS HEAD
but commenting the failing part because I have no
time yet to fix it.
Petr I do assign to the bug to you,
if you don't have time to fix it just unassign the bug.
Unlocked
2464
1255865152
Original_Submission
Thank you, Eric.
The bugfix is ready for commit. I just replaced wchar_t --> uint16_t because I didn't find a word in the standard saying this is a character type or what UTF encoding should be used.
Should I commit now, or wait until 3.3.3 is out?
gotthardp
Status
None
In Progress
gotthardp
1255886547
Original_Submission
Go ahead for the commit now.
This one should be harmless :-)
I'm late for 3.3.3 because in the first place I thought
I should be able to fix the "late arriving federate bug"
but it is not that simple to fix.
erk
1255897487
Status
In Progress
Fixed
gotthardp
Original_Submission
Thanks.
gotthardp
1255897503
Status
Fixed
Ready For Test
gotthardp
1256118645
Open/Closed
Open
Closed
erk
Fixed_Release
Unknown
3.3.3
erk
-
bugs
1251728229
27357
None
Compilation error
1256118659
CERTI
RTIA and RTIG executable wrongly depends on libRTI and libFedTime
erk
Public
3 - Normal
Closed
3.3.2
3.3.3
erk
Ready For Test
We could theoretically get rid of this spurious dependency
Unlocked
2464
27343
bugs
1251728267
Status
Confirmed
Ready For Test
erk
-
Depends on bugs #27343
erk
Fixed_Release
Unknown
CVS
erk
1256118659
Open/Closed
Open
Closed
erk
Fixed_Release
CVS
3.3.3
erk
-
bugs
1250023936
27227
Every Time
HLA compliance error
1256118675
CERTI
registerObjectInstance fails(), an object is still added to ObjectSet
erk
Public
3 - Normal
Closed
CVS
3.3.3
rleonard
Ready For Test
When registerObjectInstance() fails with an exception because the object has not been published or declared, an object with the same name cannot be registered, even if the exception has been caught and the problem resolved.
This happens because the object is added to the ObjectSet in the federation before there is a check to determine if the object has been published before. When attempting to re-register an object with the same name, the ObjectSet already contains the object from the failed register attempt.
A patch is included to solve the above problem by removing the object from the set if an exception is thrown. The patch also includes a call to the free command on objectHandles so that the handle id may be reused in the federation. However, the free function appears to be commented out so this has no effect for now, and I thought it wise to leave that alone, as it was probably commented out for a reason.
Unlocked
2464
6894
patch
1250023937
-
Added certi_registerObjectInstance.patch, #18558
rleonard
1250064803
Original_Submission
Adding dependency to patch tracker.
erk
1250064804
-
Depends on patch #6894
erk
1250064950
Status
None
In Progress
erk
Assigned_to
100
13631
erk
Original_Submission
Currently reviewing and testing the patch.
erk
1250083052
Original_Submission
The patch is almost OK.
A small remark, could you tell me why
in RootObject::registerObjectInstance
you did include both
object = objects->registerObjectInstance(the_federate, the_class,
the_object, the_object_name);
ObjectClasses->registerObjectInstance(the_federate, object, the_class);
in the try, I would rather only put the second call in the try.
Because if the first call raise an exception the
objects->deleteObjectInstance
call used in the catch patch will most probably raise another
exception too.
Am I right or did I miss something?
erk
1250083624
Original_Submission
You're absolutely right, objects->registerObjectInstance() only adds the object to the set at the very end of the function, so there's no object to delete if it throws an exception. Sorry about that.
rleonard
1250085476
Fixed_Release
Unknown
NextRelease
erk
Status
In Progress
Ready For Test
erk
Original_Submission
Ok then.
I did make the small modification and applied
the patch to CVS HEAD.
The patch did pass the current HLA TestSuite.
As a side note even if the patch should fix the problem
our current (small) HLA TestSuite does not include
a test case for this particular case.
If you are willing to implement one it would be welcomed.
It can be done either by adding a new test federate
or using one of the existing interactive federate
(create_destroy or InteractiveFederate) which may
be used along with a new dtest script.
I'll provide more info on the mailing list if your are wanting
to try that.
erk
1250086104
Original_Submission
I'd be glad to. I'm subscribed to certi-devel now.
rleonard
1250090057
Original_Submission
Ok Rod,
I'm preparing a message on the topic.
erk
1256118675
Open/Closed
Open
Closed
erk
Fixed_Release
NextRelease
3.3.3
erk
-
bugs
1242694363
26610
Every Time
Software error
1256118761
CERTI
rtig crashed when network error
erk
Public
4 - Important
Closed
3.3.2
3.3.3
musicear
Ready For Test
ritg throw exception: map/set iterator not increment when network error.
I think the funcion killFederate in ObjectSet.cc
void ObjectSet::killFederate(FederateHandle the_federate)
throw (RTIinternalError)
{
std::map<ObjectHandle, Object *>::iterator i ;
for (i = begin(); i != end(); i++) {
if ((i->second)->getOwner() == the_federate) {
std::map<ObjectHandle, Object *>::erase(i);
i = begin();
}
}
}
should change to
void
ObjectSet::killFederate(FederateHandle the_federate)
throw (RTIinternalError)
{
std::map<ObjectHandle, Object *>::iterator i = begin();
while( i != end() )
{
if ((i->second)->getOwner() == the_federate) {
std::map<ObjectHandle, Object *>::erase(i);
i = begin();
}
else
i++;
}
}
Unlocked
2464
1243444988
Status
None
Need Info
erk
Original_Submission
Sounds good, we should not
try to ++ a modified iterator which may already be at the end.
Can you describe how you make RTIG crash?
Do you kill a federate?
Do you unplug the network cable?
Does your fix works on your test case?
erk
Assigned_to
100
13631
erk
1243472962
Original_Submission
I can make RTIG crash using such code:
#define RTI_USES_STD_FSTREAM
#include <string.h>
#include <stdlib.h>
#include <RTI.hh>
#include <windows.h>
#include <sys/timeb.h>
#include <iostream>
using std::cout;
using std::cerr;
using std::endl;
int testcase()
{
RTI::FederateAmbassador *fedAmb;
RTI::RTIambassador rtiAmb;
RTI::FederateHandle federateId;
rtiAmb.createFederationExecution( "hello", "HelloWorld.fed" );
federateId = rtiAmb.joinFederationExecution( "test1",
"hello",
fedAmb);
cerr << "Do something wrong to make RTIA crash"<< endl;
rtiAmb.registerObjectInstance( 1 );
cerr << "Now RTIG crashed!"<< endl;
return 0;
}
int main()
{
testcase();
}
These code was complied in Visual Studio 2008 and make
RTIG crash every time.
My fix works on my test case.
musicear
1243501350
Original_Submission
Ok then .
I've just checked-in your fix.
It passes our [current] tests suite.
erk
Status
Need Info
Ready For Test
erk
Release
CVS
3.3.2
erk
1256118761
Open/Closed
Open
Closed
erk
Fixed_Release
CVS
3.3.3
erk
-
bugs
1242748306
26621
Every Time
Software error
1256118721
CERTI
Cannot disable HTTP proxy by setting CERTI_HTTP_PROXY=""
gotthardp
Public
3 - Normal
Closed
3.3.2
3.3.3
gotthardp
Ready For Test
As reported by Martin, the HTTP proxy cannot be disabled by setting the environment variable to an empty string
http://lists.nongnu.org/archive/html/certi-devel/2009-05/msg00022.html
Moreover, CERTI_HTTP_PROXY and http_proxy does not accept URL with the "http://" prefix.
Fixed.
Unlocked
2464
1256118721
Fixed_Release
NextRelease
3.3.3
erk
Open/Closed
Open
Closed
erk
-
bugs
1243497073
26704
Every Time
Software error
1256118711
CERTI
FedRegion and RegionImp mistakes in RTIambassador.cc
gotthardp
Public
4 - Important
Closed
3.3.2
3.3.3
musicear
Ready For Test
The function
RTI::Region *RTI::RTIambassador::createRegion
in RTIambassador.cc
return RegionImp,
but such functions:
notifyAboutRegionModification, deleteRegion, get_handle, build_region_handles
int RTIambassador.cc want FedRegion as a parament.
Rtia crash every time when calling such functions.
Unlocked
2464
1243502990
Status
None
Need Info
erk
Original_Submission
This is obviously a mistake done
when seperating libRTI types from libCERTI type.
Would you be able to provide a patch?
erk
Release
CVS
3.3.2
erk
1243503000
Fixed_Release
CVS
Unknown
erk
1243548066
-
Added breholee
breholee
1244383519
Assigned_to
100
66608
gotthardp
Original_Submission
I can fix that together with the bug #26705.
gotthardp
Status
Need Info
In Progress
gotthardp
1244387724
Original_Submission
Fixed. Please check the latest CVS.
gotthardp
Status
In Progress
Ready For Test
gotthardp
1256118711
Open/Closed
Open
Closed
erk
Fixed_Release
Unknown
3.3.3
erk
-
bugs
1243497484
26705
Every Time
Software error
1256118693
CERTI
extents and coExtents mistakes in RTItypesImp.cc
gotthardp
Public
4 - Important
Closed
3.3.2
3.3.3
musicear
Ready For Test
Because there is no way to init
std::vector<Extent> extents of class RegionImp,
so the member functions:
getRangeLowerBound, getRangeUpperBound, setRangeLowerBound,
setRangeUpperBound
will throw exception.
Unlocked
2464
1243503789
Release
CVS
3.3.2
erk
Fixed_Release
CVS
Unknown
erk
1243503790
Original_Submission
I'm not currently familiar with the Region handling code
of CERTI and the fact that it is currently broken
exhibit the fact that it has been untested for a too long time :-(.
I do not have time now to fix this, but I would suggest
to add a small "RegionTestFederate" to our HLA Tests Suite:
http://cvs.savannah.gnu.org/viewvc/applications/HLA_TestsSuite/?root=certi
in order to investigate problem and be sure that we include
such test in the future.
Would you be volunteer to do such work since I cannot give
any timeline myself?
erk
1243546993
-
Added breholee
breholee
1244383373
Original_Submission
I will fix that.
gotthardp
Status
None
In Progress
gotthardp
Assigned_to
100
66608
gotthardp
1244388193
Status
In Progress
Ready For Test
gotthardp
Original_Submission
I made a Python test script (PyHLA/test/region_creation.py).
Zhiyu: The bug you reported is fixed, but you may encounter more bugs in other DDM functions. Please don't get discouraged and keep reporting. ;-)
gotthardp
1256118693
Open/Closed
Open
Closed
erk
Fixed_Release
Unknown
3.3.3
erk
-
bugs
1248877104
27137
Every Time
Non-software error
1256118632
CERTI
CTest broken after CDash site reorganization
gotthardp
Public
3 - Normal
Closed
CVS
3.3.3
gotthardp
Ready For Test
Hi Eric,
the nightly tests are not working right now and I think it's because CDash did modify their site.
CTEST_DROP_SITE is "www.cdash.org" but should be "my.cdash.org"
CTEST_DROP_LOCATION is "/CDashPublic/submit..." but should be "submit..."
I may do the modification if you like.
Petr
Unlocked
2464
1248877670
Original_Submission
Hi Petr,
Yes no problem go ahead try the modif'
and commit them if it's ok on your side.
erk
1248879574
Original_Submission
Fixed.
gotthardp
Assigned_to
100
66608
gotthardp
Status
None
Ready For Test
gotthardp
1256118632
Open/Closed
Open
Closed
erk
Fixed_Release
NextRelease
3.3.3
erk