[Bug-zebra] Order of commands in config file

[David McCullough]

Hi,

I just encountered a problem that I am sure comes up from time to time.
I don't think it is truly a bug,  but it took me quite a while to figure
out why zebra-ripd would not parse my config file.

For example the ripd.conf:

        router rip
        access-list internal permit any
        access-list internal permit any
        network eth0
        network eth1
        distribute-list internal in  eth0
        distribute-list internal out eth0
        distribute-list external in  eth1
        distribute-list external out eth1

Will fail with an unknown command on line 'network eth0'.  While the
following file works:

        access-list internal permit any
        access-list internal permit any
        router rip
        network eth0
        network eth1
        distribute-list internal in  eth0
        distribute-list internal out eth0
        distribute-list external in  eth1
        distribute-list external out eth1

Basically,  the file parser requires the "router rip" line before any
rip commands.  You cannot intermix different NODE commands in whatever
order you desire without putting "router rip" before each group of rip
commands.

I have attached a patch that I think goes a long way to resolving this kind
of issue.  Someone who understands the parser a lot better than me should
probably look at it and see if it is a safe thing to do.  I have not
extensively tested this patch,  I just made sure it could handle config
files like those above.

If the above behaviour is the intended operation,  an explicit note in the
doc would be nice :-)

Thanks for a great routing package,
Davidm

-- 
David McCullough:  Ph: +61 7 3279 1822  Lineo (The Embedded Linux Company)
address@hidden   Fx: +61 7 3279 1820  PO Box 925, Kenmore QLD 4069, Australia

zebra.patch
Description: zebra-0.88.patch