Re: [Bug-XBoard] font name declaration bug

[Tim Mann]

No. The macros use C's automatic string concatenation feature.  This macro:

#define CLOCK_FONT_NAME \
  "-*-helvetica-bold-r-normal--*-*-*-*-*-*-*-*," \
  "-misc-fixed-bold-r-normal--*-*-*-*-*-*-*-*," \
  "-*-*-*-*-*-*-*-*-*-*-*-*-*-*"

means the same as


#define CLOCK_FONT_NAME
"-*-helvetica-bold-r-normal--*-*-*-*-*-*-*-*,-misc-fixed-bold-r-normal--*-*-*-*-*-*-*-*,-*-*-*-*-*-*-*-*-*-*-*-*-*-*"


That is how the macro is supposed to be defined, because it is
defining just one string, with commas inside it.The code that uses
this macro parses the string and splits it up at the commas. I wrote
the code to do that and I actually do know what I'm doing.

If you moved the commas where you think they should go, the macro
would be defining three separate strings with commas in between. That
probably would not give you a compilation error because the commas
would be interpreted as C's comma operator, but it would be wrong.
With the comma operator there, in effect the first two strings would
end up being ignored and only the last one would be used at all.

Did you actually try this and have it work better for you? If so,
exactly what problem were you seeing before you made the change?
Moving the commas to the wrong place is not the right fix for it.

On Sun, Feb 9, 2014 at 8:51 PM, Александр Дидин <address@hidden> wrote:
> To be more precise, it concerns distribution from 
> http://ftp.gnu.org/gnu/xboard/
> xboard-4.7.2.tar.gz
>
> 10.02.2014, 04:39, "Tim Mann" <address@hidden>:
>> That is not a bug. Those options take a string consisting of font
>> patterns separated by commas. If no match is found for the first
>> pattern, xboard tries the second one, etc. The commas are a part of
>> the string.
>>
>> On Sun, Feb 9, 2014 at 6:44 AM, Александр Дидин <address@hidden> wrote:
>>
>>>  Hi,
>>>  there are misplaced commas "," in the font declarations in files xboard.h:
>>>
>>>  #define CLOCK_FONT_NAME \
>>>    "-*-helvetica-bold-r-normal--*-*-*-*-*-*-*-*," \
>>>    "-misc-fixed-bold-r-normal--*-*-*-*-*-*-*-*," \
>>>    "-*-*-*-*-*-*-*-*-*-*-*-*-*-*"
>>>  #define COORD_FONT_NAME \
>>>    "-*-helvetica-bold-r-normal--*-*-*-*-*-*-*-*," \
>>>    "-misc-fixed-bold-r-normal--*-*-*-*-*-*-*-*," \
>>>    "-*-*-*-*-*-*-*-*-*-*-*-*-*-*"
>>>  #define DEFAULT_FONT_NAME \
>>>    "-*-helvetica-medium-r-normal--*-*-*-*-*-*-*-*," \
>>>    "-misc-fixed-medium-r-normal--*-*-*-*-*-*-*-*," \
>>>    "-*-*-*-*-*-*-*-*-*-*-*-*-*-*"
>>>
>>>  Best regards,
>>>  Alexandr
>>>
>>>  _______________________________________________
>>>  Bug-XBoard mailing list
>>>  address@hidden
>>>  https://lists.gnu.org/mailman/listinfo/bug-xboard