Re: [Bug-wget] [PATCH] Anyone want to add libcares support to wget?

[Ben Greear]

On 03/20/2016 12:32 PM, Tim Rühsen wrote:
> Am Sonntag, 20. März 2016, 17:21:11 schrieb Daniel Stenberg:
> > On Sun, 20 Mar 2016, Tim Rühsen wrote:
> > > Here comes the first version of the patch.
> >
> > The c-ares library is called libcares.
>
> Here comes patch #2, naming changed to libcares.
> Also --dns-timeout now works libcares code.

As far as I can tell, this is working.  We will continue to do more
testing, and will let you all know if we find any problems.

One issue with the patch, the description is wrong:

"The new options allow to specify alternative DNS servers and
an alternate packet route for the resolver packets.
Wget has to built with libares, enabled at configure time by
./configure --with-ares."

This should be '--with-cares'

I have not tried the DNS timeout logic.

The commands I did test were:

./wget --bind-address 192.168.100.240 --dns-servers 8.8.8.8 --bind-dns-address 
192.168.100.135 http://www.candelatech.com/index.php

and

./wget --bind-address 192.168.100.240 --dns-servers 8.8.8.8 --bind-dns-address 
192.168.100.240 http://www.candelatech.com/index.php

# cat /etc/resolv.conf
search candelatech.com.
nameserver 192.168.100.1

(So, if it is using 8.8.8.8 for DNS server, then I know it is not using system 
defaults.)

Those IP addresses in the wget commands are associated with mac-vlan interfaces 
on my 'eth0' interface.  I sniffed each mac-vlan to ensure
that the traffic was properly associated with the correct IP and interface.  I 
use policy-based routing rules to ensure
than pkts with specific source-IPs use specific routing tables, so that is how 
I know on which interface I should see
traffic.

Tim, thank you for your quick and professional work!

Thanks,
Ben


--
Ben Greear <address@hidden>
Candela Technologies Inc  http://www.candelatech.com