Re: [Bug-wget] Implement --pinnedpubkey option to pin public keys

[moparisthebest]

Hi Tim,

I've implemented your suggestions below, except the python tests, and
rebased on top of current HEAD, attached is the patch.

The documentation in testenv/ says the test server doesn't support
https, which would be needed for this test.  Has anyone started work on
that?  Or would it be acceptable to just use socat or stunnel or similar
in front of the current test server?

Thanks much,
Travis

On 03/15/2016 07:50 AM, Tim Ruehsen wrote:
> Hi Travis,
>
> thanks for poking. I started testing... just a few more points.
>
> In wg_pin_peer_pubkey(), what is this loop do {...} while(0) about ?
> I looks like it is not supposed to loop (if it would, we had resource leaks). 
> Maybe you can remove it and instead of 'break: do a 'goto end/cleanup/out' !?
>
> Please consider to use wget_read_file / wget_read_file_free() for reading the 
> contents of a file. It also allows for stdin ('-' at the command line) which 
> makes the new option a bit more consistent with Wget's CLI standards.
>
> Do you plan to create a python test (see testenv/) ?
>
> Regards, Tim
>
> On Monday 14 March 2016 12:57:52 moparisthebest wrote:
>> Hi all,
>>
>> Just checking back in about this patch, is there anything else you are
>> waiting on from me before integrating it?
>>
>> Thanks much,
>> Travis

0001-Implement-pinnedpubkey-option-to-pin-public-keys.patch
Description: Text Data

signature.asc
Description: OpenPGP digital signature