bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Bug-Wget] Global gitignore


From: Darshit Shah
Subject: Re: [Bug-wget] [Bug-Wget] Global gitignore
Date: Fri, 25 Jul 2014 13:04:06 +0530

I've attached another patch with the files in the project root
prefixed with a /.


As stated in my last mail, I believe that splitting the .gitignore
file into multiple small ones across directories isn't worth the
effort and any speedup it may provide will not be quantifiable in the
forseeable future. Hence, this patch contains only a single .gitignore
for the complete project.

If others feel that splitting the gitignore file is the best way
forward, we can discuss that and make the relevant changes to the
patch.

Simultaneously, I'd also like to request everyone to test this patch
out to see of I've missed any autogenerated files in the project.

On Thu, Jul 24, 2014 at 2:11 PM, Darshit Shah <address@hidden> wrote:
> On Thu, Jul 24, 2014 at 2:00 PM, Duy Nguyen <address@hidden> wrote:
>> On Thu, Jul 24, 2014 at 2:12 PM, Darshit Shah <address@hidden> wrote:
>>> Probably. I simply redirected the output of 'git status' and manually 
>>> sorted them into the directories.
>>
>> Split them in multiple .gitignore (per directory) is good. A single
>> large .gitignore may slow things down. See
>> http://article.gmane.org/gmane.comp.version-control.git/194294
>>
> Thanks for the link! Thinking about it, one should have expected that.
> However, Wget is not WebKit. We don't have a large number of files and
> the number isn't increasing over time at any significant rate. `time
> git status` on my machine with the above gitignore file takes 0.05s.
> Is any speedup beyond this worth the effort of maintaining several
> different gitignore files?
>
>>> However why is a slash prefix a good idea?
>>
>> It gives git a hint that these entries only apply to top-level
>> directory, so git can ignore them when examining subdirectories
>>
> This on the other hand is a nearly effortless way of getting a small
> speedup in git. I'll add those.
>
>>>
>>> --
>>> Sent from Mailbox
>>>
>>> On Thu, Jul 24, 2014 at 12:52 AM, Ángel González <address@hidden>
>>> wrote:
>>>
>>>> Darshit Shah wrote:
>>>>> Hi,
>>>>>
>>>>> When building the repository sources, a large number of files are
>>>>> autogenerated and hence are not version controlled in git.
>>>>> However, all these files pollute the output of commands like `git
>>>>> status`. The only way around it is to place all the autogenerated
>>>>> files in a single .gitignore file and share it with the repository
>>>>> itself.
>>>>>
>>>>> I've compiled a .gitignore that can be used in Wget's repository. This
>>>>> file ignores all the autogenerated files due to bootstrap, configure,
>>>>> make and make check.
>>>>> On top of it, I've also ignored some extra files like tags and
>>>>> cscope.out which I assume a lot of developers are probably using. I've
>>>>> attached the file for everyone's convenience here. Maybe we can ship
>>>>> this file with the sources itself?
>>>> +1
>>>> But I would prefix with a slash the files in the Project Root.
>>
>>
>>
>> --
>> Duy
>
>
>
> --
> Thanking You,
> Darshit Shah



-- 
Thanking You,
Darshit Shah

Attachment: 0001-Add-a-project-gitignore-file.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]