[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [Bug-Wget] Misc. patches
From: |
Darshit Shah |
Subject: |
Re: [Bug-wget] [Bug-Wget] Misc. patches |
Date: |
Mon, 7 Jul 2014 17:08:48 +0530 |
The version on origin/master is the latest version. The slight
amendment I made was using this snippet:
@@ -519,7 +531,21 @@ check_domain_match (const char *cookie_domain,
const char *host)
goto no_psl;
}
- is_acceptable = psl_is_cookie_domain_acceptable (psl, host, cookie_domain);
+ if (psl_str_to_utf8lower (cookie_domain, NULL, NULL,
&cookie_domain_lower) == PSL_SUCCESS &&
+ psl_str_to_utf8lower (host, NULL, NULL, &host_lower) == PSL_SUCCESS)
+ {
+ is_acceptable = psl_is_cookie_domain_acceptable (psl,
host_lower, cookie_domain_lower);
+ }
+ else
+ {
+ DEBUGP (("libpsl unable to parse domain name. "
+ "Falling back to simple heuristics.\n"));
+ goto no_psl;
+ }
+
+ xfree (cookie_domain_lower);
+ xfree (host_lower);
+
return true ? (is_acceptable == 1) : false;
no_psl:
Notice I changed the conditional statement to check for PSL_SUCCESS as
a return value.
On Mon, Jul 7, 2014 at 4:43 PM, Tim Ruehsen <address@hidden> wrote:
> On Saturday 05 July 2014 16:38:54 Darshit Shah wrote:
>> I just pushed a slightly amended patch. However, here is what I propose:
>
> Where did you push it to ?
> Git pull on master still has the previous version...
>
> Tim
>
--
Thanking You,
Darshit Shah
- [Bug-wget] [Bug-Wget] Misc. patches, Darshit Shah, 2014/07/05
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Giuseppe Scrivano, 2014/07/05
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Darshit Shah, 2014/07/05
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Giuseppe Scrivano, 2014/07/05
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Darshit Shah, 2014/07/05
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Tim Ruehsen, 2014/07/07
- Re: [Bug-wget] [Bug-Wget] Misc. patches,
Darshit Shah <=
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Tim Ruehsen, 2014/07/07
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Tim Ruehsen, 2014/07/07
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Darshit Shah, 2014/07/20
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Tim Rühsen, 2014/07/20
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Darshit Shah, 2014/07/21
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Giuseppe Scrivano, 2014/07/21
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Tim Rühsen, 2014/07/22
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Darshit Shah, 2014/07/23
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Darshit Shah, 2014/07/19
- Re: [Bug-wget] [Bug-Wget] Misc. patches, Tim Rühsen, 2014/07/19