[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] http.c code cleaning
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] http.c code cleaning |
Date: |
Wed, 08 May 2013 21:51:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Darshit Shah <address@hidden> writes:
>>
>> In comment to `request_new` was that it *always* must be followed by
>> `request_set_method`. I changed code to combine these functionality into
>> single function. Please, review.
>
> Looks good to me.
> Just one thing though, the method string is now converted to uppercase
> through cmd_string_uppercase.
> Giuseppe pushed a patch with that change a few days ago.. Please rebase it
> onto the master branch.
Good idea, but as Darshit said, please rebase it onto the master branch.
I will be offline for the next few days, I will review it when I am back.
--
Giuseppe
- [Bug-wget] http.c code cleaning, Dmitry Bogatov, 2013/05/08
- Re: [Bug-wget] http.c code cleaning, Darshit Shah, 2013/05/08
- Re: [Bug-wget] http.c code cleaning,
Giuseppe Scrivano <=
- Re: [Bug-wget] http.c code cleaning, Dmitry Bogatov, 2013/05/08
- Re: [Bug-wget] http.c code cleaning, Giuseppe Scrivano, 2013/05/08
- Re: [Bug-wget] http.c code cleaning, Dmitry Bogatov, 2013/05/09
- Re: [Bug-wget] http.c code cleaning, Darshit Shah, 2013/05/09
- Re: [Bug-wget] http.c code cleaning, Dmitry Bogatov, 2013/05/10
- Re: [Bug-wget] http.c code cleaning, Giuseppe Scrivano, 2013/05/12