Re: texinfo 7.1: Segmentation fault when including texi file

[Christoph Scholtes]

Thank you, Pat.

I confirm that your fix resolves the issue in my build of glibc 2.23.

Christoph

On Wed, May 1, 2024 at 7:43 AM Patrice Dumas <pertusus@free.fr> wrote:

On Mon, Apr 29, 2024 at 08:58:12PM -0600, Christoph wrote:
> Hello,
>
> The build process fails during install target with a segmentation fault and
> the following message:
> texi2any (XS parser): bug: parent hv not already set
>
> I was able to create a minimal example to reproduce the issue outside of
> the glibc build process itself:

Thanks a lot for the report.  It should be fixed in the commit
https://git.savannah.gnu.org/cgit/texinfo.git/commit/?id=60d3edc4b74b4e1e5ef55e53de394d3b65506c47
for the devel version.

The issue was that the @include parent element is removed from the
Texinfo tree in the specific case you unveiled, while the @include
element is still present in 'out of tree' source marks that keeps the
code removed from the tree.

I removed the link to the @include parent element, as done for other
source marks, which fixes the bug.

> I have confirmed that the issue only occurs with texinfo 7.1+ and is not
> present in earlier versions.

I'll let Gavin decide if he wants to have it applied to the bugfix
branch.

> The latest development version of 7.1
> (1fdf0183654700f2d72f706ab96b0b8456cf58fc) has the same issue, but there is
> a little bit more information in the error message shown, which might be
> helpful to debug:
> texi2any (XS parser): bug: parent 0x56d882087aa0 hv not set in @include[A1]
> <- @iftex '@include summary.texi

The additional information is not that useful, actually, as because the
memory is incorrectly layout because of the bug, some additional
information is incorrect (namely that @iftex is @include parent...).

--
Pat