Re: Texinfo 7.0.94 pretest available

[Gavin Smith]

On Sun, Oct 15, 2023 at 12:00:47PM +0300, Eli Zaretskii wrote:
> Thanks.
> 
> This doesn't compile with MinGW, because some of the dTHX additions I
> needed for the previous pretest were not installed(?), and are still
> missing.  The patch I needed is below.

I hadn't installed those changes because I hadn't understood why they
were necessary.  Looking at the code, I expect that it was due to the
use of fprintf in those functions which the Perl headers must be doing
something funny with.  Presumably you got an error message when compiling
indicating this?

The fprintf calls were added since the Texinfo 7.0 branch so will not
have broken previously.

Although adding dTHX should be harmless, the paragraph formatting
functions are very frequently called functions and adding the dTHX in
there has a potential performance impact, especially in xspara__add_next.

However, I could not detect any performance difference in the testing I
did so I have added them anyway.