[Bug-tar] tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition

[David Binderman]

Hello there,

tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition (assignment + comparison); Clarify _expression_ with parentheses.

Source code is

       if (mode == O_RDONLY

                  || (new_fd = open ("/dev/full", mode) != fd))

Maybe better code

       if (mode == O_RDONLY

                  || ((new_fd = open ("/dev/full", mode)) != fd))

Regards

David Binderman