bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-tar] paxutils: rmt.c missing va_end()


From: Pavel Raiskup
Subject: [Bug-tar] paxutils: rmt.c missing va_end()
Date: Mon, 30 Jul 2018 09:48:51 +0200

Hi,

please consider fixing rmt_write function:

  rmt_write (const char *fmt, ...)
  {
    va_list ap;
    va_start (ap, fmt);
    vfprintf (stdout, fmt, ap);
    // missing va_end
    fflush (stdout);
    VDEBUG (10, "S: ", fmt, ap);
    // potential re-use of 'ap' (requires new va_start)
  }

the first issue is not a problem in GNU/Linux GCC/Glibc ecosystem, but
still it seems to be good candidate for fix for compatibility.

Pavel






reply via email to

[Prev in Thread] Current Thread [Next in Thread]