[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] [PATCH] Re: Detection of sparse files is broken on btrfs
From: |
Pavel Raiskup |
Subject: |
Re: [Bug-tar] [PATCH] Re: Detection of sparse files is broken on btrfs |
Date: |
Tue, 09 Jan 2018 09:25:40 +0100 |
On Tuesday, January 9, 2018 8:59:06 AM CET Paul Eggert wrote:
> Pavel Raiskup wrote:
> > So what about special casing that filesystem, where we can lseek() for
> > holes anyway?
>
> If we can lseek for holes, then why not just do that?
Checking whether lseek() actually works costs some additional syscalls _per
sparse_ file; checking for ST_NBLOCKS() is without this penalty.
> We shouldn't need special-case code for btrfs per se. Any filesystem
> where we can lseek for holes should take advantage of that optimization.
It is done so actually, the 'wholesparse' is another optimization on top
of that (but usable also in cases where SEEK_HOLE isn't defined at all).
Pavel
- Re: [Bug-tar] Detection of sparse files is broken on btrfs, (continued)
- Re: [Bug-tar] Detection of sparse files is broken on btrfs, Andreas Dilger, 2018/01/22
- Re: [Bug-tar] Detection of sparse files is broken on btrfs, Joerg Schilling, 2018/01/23
- Re: [Bug-tar] Detection of sparse files is broken on btrfs, Mark H Weaver, 2018/01/08
- Re: [Bug-tar] Detection of sparse files is broken on btrfs, Mark H Weaver, 2018/01/09
- Re: [Bug-tar] Detection of sparse files is broken on btrfs, Ralph Corderoy, 2018/01/08
[Bug-tar] [PATCH] Re: Detection of sparse files is broken on btrfs, Pavel Raiskup, 2018/01/09
Re: [Bug-tar] [PATCH] Re: Detection of sparse files is broken on btrfs, Joerg Schilling, 2018/01/09