[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] --sparse is broken on filesystems where small files may ha
From: |
Andrew J. Schorr |
Subject: |
Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks |
Date: |
Tue, 29 Oct 2013 08:16:39 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
On Tue, Oct 29, 2013 at 08:03:47AM -0400, Andrew J. Schorr wrote:
> Thanks for the patch, but I don't think that fixes the problem in
> sparse.c:sparse_scan_file where it says
>
> if (ST_NBLOCKS (st->stat) == 0)
> offset = st->stat.st_size;
> else
> ...
To be clear, I can see that the fix to ST_IS_SPARSE should cause
dump_regular_file to be called instead of sparse_dump_file, but I still
wonder if it is wise to leave this logic in place. At the very last,
I think a comment would be helpful to explain that this test is valid
only because ST_IS_SPARSE has already succeeded.
Regards,
Andy
- [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Andrew J. Schorr, 2013/10/28
- Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Paul Eggert, 2013/10/29
- Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Pavel Raiskup, 2013/10/29
- Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Pavel Raiskup, 2013/10/29
- Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Joerg Schilling, 2013/10/29
- Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Christoph Hellwig, 2013/10/30
- Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Jan Kara, 2013/10/30
- Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Andreas Dilger, 2013/10/29
- Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Carlos Maiolino, 2013/10/31
Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks, Andrew J. Schorr, 2013/10/29