bug-standards
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Criteria for Acceptable Git to ChangeLog


From: John Darrington
Subject: Re: Criteria for Acceptable Git to ChangeLog
Date: Tue, 15 May 2018 14:41:48 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Sat, May 12, 2018 at 05:19:55PM -0400, Richard Stallman wrote:
     
     I think we need something that will generate, from the repo, the list
     of entities changed -- reliably enough that errors are rare and not a
     problem.

Let us restrict the discussion to C for the time being.  I think in this case
"entities" are :

 * files
 * functions
 * variables not in global scope

I don't think it's necessary to identify, for example the variable "i" in
for (int i = 0; i < 10; ++i)

Do you have a different understanding of what entities are ?

     
     As for the descriptions of the changes in each entity, that is important
     when the change in an entity is complex enough to want description.
     We could put that sort of info in commit messages, by saying something
     about how the change works.

I am of the opinion that a commit message/changelog description should say 
*why* a change was made, rather than to elaborate or summarize on *what* 
change was made.  After all, what change was made can be determined from 
the repository, and if any explanation is necessary they should be put in
as comments in the code.


J'


-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]