Re: [bug-patch] "make check" failures (latest in git)

[Andreas Gruenbacher]

On Sunday, 29 March 2009 10:18:08 Jim Meyering wrote:
> Hi,
>
> Using the latest from git,
>
>   commit df890caf03184fe72f6aa25f9392a46dd187f90f
>   Date:   Sun Mar 29 00:39:48 2009 +0100
>
> when I run "make -j1 check", I get this:
>
>   [tests/backup-prefix-suffix]
>   [24] patch -b -p1 < ab.diff -- ok
>   [28] cat f.orig -- FAILED
>   --- expected
>   +++ got
>   @@ -1 +1 @@
>   -one
>   +cat: f.orig: No such file or directory

Thanks for testing.

You probably have SIMPLE_BACKUP_SUFFIX, VERSION_CONTROL, or 
PATCH_VERSION_CONTROL set in the environment. I have fixed the test suite in 
commit af57793 now. In case that shouldn't help, what does the attached patch 
give?

> And when I run "make -j4 check", I get even more,
> which makes me think the individual tests are not
> yet isolated enough to be run in parallel:

They should run fine in parallel, but the output isn't very useful. In case 
there are still failures, what does "make -k check" give?

Note that since commit 17c16b6 (Avoid replacing files when nothing has 
changed), no backup files get created when nothing has changed, either. I'm 
looking into this right now.

Andreas

debug.diff
Description: Text Data