Re: [PATCH] tests: stop using private "dev" directory for losetup

[Jim Meyering]

Stefano Lattarini wrote:

> Hi Jim.
>
> I think I might have spotted a little typo ...
>
> On 10/06/2012 11:45 AM, Jim Meyering wrote:
>> This root-only test had been failing for me for a while.
>> Something changed (kernel? losetup? SELinux?) about how device
>> files not under /dev/ are handled, so I've removed the
>> useless-for-loopback-files hack of using a private /dev directory.
>>
>> From 478e472bf9f1c76b66a35ea75b45110152e5207d Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <address@hidden>
>> Date: Sat, 6 Oct 2012 11:11:32 +0200
>> Subject: [PATCH] tests: stop using private "dev" directory for losetup
>>
>> Something about Fedora 17's losetup changed so that using a private
>> dev directory no longer worked.  Now, simply use /dev/ directly.
>> * tests/t-lvm.sh: Don't use $G_dev_.  Not needed, and actually
>> caused the t6000-dm root-only test to fail on Fedora 17.
>> Also, redirect less to stderr: that helps diagnose failure.
>>
> ... here: should it be s|stderr|/dev/null| ?

Hi Stefano,

Thank you!  You're right.
If I'd known I would be seeing such prompt feedback I would have waited.
Unfortunately I pushed more or less immediately, so I'll repair it via
our ChangeLog adjustment process:

>From 718ac7342412aa7f32aaf3e9f379beb84883406e Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 6 Oct 2012 15:09:56 +0200
Subject: [PATCH] maint: fix an error in the preceding commit log

Stefano Lattarini noticed an error in the log for
commit v3.1-32-g478e472.  Arrange for that error
to be fixed in the generated ChangeLog file.
* build-aux/git-log-fix: New file.
* Makefile.am (gen-ChangeLog): Adjust rule to use it.
---
 .gitignore            | 3 ++-
 Makefile.am           | 1 +
 build-aux/git-log-fix | 7 +++++++
 3 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 build-aux/git-log-fix

diff --git a/.gitignore b/.gitignore
index 054d9ea..5bb95d4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -32,7 +32,8 @@ Makefile.in
 TAGS
 aclocal.m4
 autom4te.cache
-build-aux
+/build-aux/*
+!/build-aux/git-log-fix
 config.cache
 config.h
 config.hin
diff --git a/Makefile.am b/Makefile.am
index 5e52a42..686b61c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -107,6 +107,7 @@ gen_start_date = 2000-01-01
 gen-ChangeLog:
        if test -d .git; then                                           \
          $(top_srcdir)/build-aux/gitlog-to-changelog                   \
+           --amend=$(srcdir)/build-aux/git-log-fix                     \
            --since=$(gen_start_date) > $(distdir)/cl-t;                \
          rm -f $(distdir)/ChangeLog;                                   \
          mv $(distdir)/cl-t $(distdir)/ChangeLog;                      \
diff --git a/build-aux/git-log-fix b/build-aux/git-log-fix
new file mode 100644
index 0000000..e2a68ee
--- /dev/null
+++ b/build-aux/git-log-fix
@@ -0,0 +1,7 @@
+# This file is expected to be used via gitlog-to-changelog's --amend=FILE
+# option.  It specifies what changes to make to each given SHA1's commit
+# log and metadata, using Perl-eval'able expressions.
+
+478e472bf9f1c76b66a35ea75b45110152e5207d
+# Fix the log message:
+s,stderr,/dev/null,
--
1.8.0.rc0.18.gf84667d