Re: [PATCH 4/5] Fix loop test

[Jim Meyering]

Phillip Susi wrote:
> t8001-loop-blkpg.sh relied on loop being a loadable module and loading
> it with the max_part argument.  This is no longer required.
>
> Signed-off-by: Phillip Susi <address@hidden>
> ---
>  tests/t8001-loop-blkpg.sh |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/tests/t8001-loop-blkpg.sh b/tests/t8001-loop-blkpg.sh
> index 20bbdf5..b3b180a 100755
> --- a/tests/t8001-loop-blkpg.sh
> +++ b/tests/t8001-loop-blkpg.sh
> @@ -26,14 +26,6 @@ cleanup_fn_()
>    test -n "$loopdev" && losetup -d "$loopdev"
>  }
>
> -# If the loop module is loaded, unload it first
> -if lsmod | grep '^loop[[:space:]]'; then
> -    rmmod loop || fail=1
> -fi
> -
> -# Insert loop module with max_part > 1
> -modprobe loop max_part=7 || fail=1
> -
>  # Create backing file
>  dd if=/dev/zero of=backing_file bs=1M count=4 >/dev/null 2>&1 || fail=1

Thanks.
This patch looks sensible, so I'll go ahead and apply it in spite
of the current test failures I'm seeing.  I trust that with your
kernel, the new test does pass a root-run "make check".