[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] maint: a little defensive programming in a test script
From: |
Jim Meyering |
Subject: |
[PATCH] maint: a little defensive programming in a test script |
Date: |
Sat, 26 Nov 2011 11:17:01 +0100 |
FYI,
>From eec497c07caaff5ef297f75ee87f5dff88cacd27 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 11 Nov 2011 09:50:51 +0100
Subject: [PATCH] maint: a little defensive programming in a test script
* tests/gpt-header-munge: Use "local *F;" to limit scope of
file handles.
---
tests/gpt-header-munge | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/gpt-header-munge b/tests/gpt-header-munge
index 9b869dd..e7d3d43 100755
--- a/tests/gpt-header-munge
+++ b/tests/gpt-header-munge
@@ -64,6 +64,7 @@ sub partition_array_start_offset ($$)
sub partition_array_crc ($$$)
{
my ($pri_or_backup, $n_pe, $in) = @_;
+ local *F;
open F, '<', $in
or die "$ME: failed to open $in: $!\n";
@@ -78,7 +79,6 @@ sub partition_array_crc ($$$)
my $n = $n_pe * $pe_size;
($p = sysread F, $pe_buf, $n) && $p == $n
or die "$ME: $in: failed to read $pri_or_backup partition array:($p:$n)
$!\n";
- close F;
return crc32 $pe_buf;
}
@@ -220,6 +220,7 @@ EOF
or (warn "$ME: no file specified\n"), usage 1;
my $in = $ARGV[0];
+ local *F;
open F, '<', $in
or die "$ME: failed to open $in: $!\n";
--
1.7.8.rc3.31.g017d1
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] maint: a little defensive programming in a test script,
Jim Meyering <=