[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] libparted: make pc98 detection depend on signatures (#64
From: |
Brian C. Lane |
Subject: |
Re: [PATCH 2/3] libparted: make pc98 detection depend on signatures (#646053) |
Date: |
Mon, 17 Oct 2011 10:45:09 -0700 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Oct 15, 2011 at 11:10:38AM +0200, Jim Meyering wrote:
> Hi Brian,
>
> Thanks for the patch.
> However, do you really intend to remove those check_partition_consistency
> calls? That seems like it would weaken the test unnecessarily.
As far as I can tell there isn't a consensus on what is valid for PC98
so I opted to just make it signature based.
>
> Also, would you please change the name to pc98_valid_ipl_signature?
> That will make it more readable for me. With the "_check_" name,
> I find that I have to read the code to determine the semantics.
> While with "_valid_...", it's obviously a boolean.
> And then you can change the last four lines to be simply this:
>
> return pc98_valid_ipl_signature (&part_table);
>
Actually, _check_ is consistent with the code (eg. the check_magic
code).
> Finally, please always configure with
>
> ./configure --enable-gcc-warnings
>
> That would have highlighted some unused variables and the unused function.
Sorry about that, I build it using the fedora build scripts and missed
that one. Enclosed is an updated patch.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
0001-libparted-make-pc98-detection-depend-on-signatures-6.patch
Description: Text document
pgpvIjpyx4vgs.pgp
Description: PGP signature