Re: [PATCH parted 1/5] libparted: add ped_device_get_xxx_aligment() functions

[Hans de Goede]

Hi,

On 10/28/2009 10:26 PM, Jim Meyering wrote:
> Hans de Goede wrote:
> > Note, these patches may apply to master with a couple of lines offset
> > left and right, as I also have some patches in my local tree to update
> > parted to keep working with upcoming lvm2 (libdevmapper) changes, I'm still
> > waiting on testing feedback for these (the libdevmapper) patches before
> > submitting them.
> >
> > Regards,
> >
> > Hans
> >
> > p.s.
> >
> > I also plan to backport this set of 5 to libparted-1.9 and add them to the
> > Fedora packages for F-13.
> >
> > On 10/28/2009 10:20 PM, Hans de Goede wrote:
> > > Add ped_device_get_minimal_aligment() and ped_device_get_optimal_aligment()
> > > functions to libparted.
> > > ---
> > >    include/parted/device.h  |    8 ++++++++
> > >    include/parted/natmath.h |    1 +
> > >    libparted/device.c       |   18 ++++++++++++++++++
> > >    3 files changed, 27 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/parted/device.h b/include/parted/device.h
> > > index 151305f..31aec86 100644
> > > --- a/include/parted/device.h
> > > +++ b/include/parted/device.h
> > > @@ -92,6 +92,8 @@ struct _PedDevice {
> > >            void*           arch_specific;
> > >    };
> > >
> > > +#include<parted/natmath.h>
> > > +
> > >    /**
> > >     * List of functions implementing architecture-specific operations.
> > >     */
> > > @@ -112,6 +114,9 @@ struct _PedDeviceArchOps {
> > >            PedSector (*check) (PedDevice* dev, void* buffer,
> > >                                PedSector start, PedSector count);
> > >            void (*probe_all) ();
> > > +        /* These functions are optional */
> > > +        PedAlignment* (*get_minimal_aligment)(PedDevice* dev);
> > > +        PedAlignment* (*get_optimal_aligment)(PedDevice* dev);
>
> Please add "const" and adjust spacing: space before "*", not after:

I used the * placing which was already used in other parts of that file, but
I'm happy to slowly mover over parted to a more sane coding style.

Both fixed, I'll go over my entire patchset for this and other style issues,
and then resend the set with all style issues (including trailing whitespace)
fixed.

Regards,

Hans