Re: [PATCH] fix HDIO_GETGEO ioctl for linux

[Szakacsits Szabolcs]

On Fri, 18 Nov 2005, Harley D. Eades III wrote:
> On Thu, 2005-11-17 at 16:12 -0200, Otavio Salvador wrote:
> > "Harley D. Eades III" <address@hidden> writes:
> > 
> > >> So the question is, if /sys/firmware/edd doesn't exist, do we attempt to
> > >> `modprobe edd` from within libparted?  Or is that something that
> > >> libparted should not be doing?
> > > I don't think libparted should be using modprobe to check/init a module.

I don't think either. An error/warning with a hint what user could do 
should be enough.

> > > We could make edd a prereq for libparted or we could find another way
> > > which doesn't involve the use of a linux kernel module.

BIOS call.

> > I'm not sure of this could help but I prefer to send it anyway.
> > 
> > In grub, Fedora folks did a patch to include geometry calc there. Do a
> > look in:
> > 
> > http://svn.debian.org/wsvn/pkg-grub/grub/trunk/debian/patches/geometry-26kernel.diff?op=file&rev=0&sc=0http://svn.debian.org/wsvn/pkg-grub/grub/trunk/debian/patches/geometry-26kernel.diff?op=file&rev=0&sc=0
> > 
> It looks like they added all the necessary "things" to grub instead of
> relying on the kernel to get the geom.  Or am I reading this wrong?

They read it from the partition table but parted can't do it when it needs 
to check whether the value is correct there because that were always true 
which is obviously false.

        Szaka