address@hidden: Bug#105529: parted doesn't build on ia64]

[Timshel Knoll]

Hi Andrew,

There've been problems building parted on ia64 ... more -Werror stuff.
Patch from Jeff Licquia is attached ...

----- Forwarded message from Jeff Licquia <address@hidden> -----

Subject: Bug#105529: parted doesn't build on ia64
Reply-To: Jeff Licquia <address@hidden>, address@hidden
Resent-From: Jeff Licquia <address@hidden>
Resent-To: address@hidden
Resent-Cc: Timshel Knoll <address@hidden>
Resent-Date: Mon, 16 Jul 2001 18:33:13 GMT
Resent-Message-ID: <address@hidden>
Resent-Sender: address@hidden
X-Debian-PR-Message: report 105529
X-Debian-PR-Package: parted
X-Debian-PR-Keywords: 
From: Jeff Licquia <address@hidden>
To: address@hidden

Package: parted
Version: 1.4.15-1
Severity: serious

parted doesn't build on ia64:

 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../include -O2 -D_REENTRANT 
-DLOCALEDIR=\"/usr/share/locale\" -DLOCALEDIR=\"/usr/share/locale\" -W -Wall 
-Wno-unused -Wno-switch -Werror -c hfs.c  -fPIC -DPIC -o hfs.o
    cc1: warnings being treated as errors
    In file included from /usr/include/asm/page.h:12,
    from hfs.c:37:
    /usr/include/asm/types.h:32: warning: redefinition of `int8_t'
    /usr/include/sys/types.h:184: warning: `int8_t' previously declared here
    /usr/include/asm/types.h:33: warning: redefinition of `u_int8_t'
    /usr/include/sys/types.h:190: warning: `u_int8_t' previously declared here
    /usr/include/asm/types.h:35: warning: redefinition of `int16_t'
    /usr/include/sys/types.h:185: warning: `int16_t' previously declared here
    /usr/include/asm/types.h:36: warning: redefinition of `u_int16_t'
    /usr/include/sys/types.h:191: warning: `u_int16_t' previously declared here
    /usr/include/asm/types.h:38: warning: redefinition of `int32_t'
    /usr/include/sys/types.h:186: warning: `int32_t' previously declared here
    /usr/include/asm/types.h:39: warning: redefinition of `u_int32_t'
    /usr/include/sys/types.h:192: warning: `u_int32_t' previously declared here
    /usr/include/asm/types.h:41: warning: redefinition of `int64_t'
    /usr/include/sys/types.h:187: warning: `int64_t' previously declared here
    /usr/include/asm/types.h:42: warning: redefinition of `u_int64_t'
    /usr/include/sys/types.h:193: warning: `u_int64_t' previously declared here
    make[4]: *** [hfs.lo] Error 1





----- End forwarded message -----

----- Forwarded message from Jeff Licquia <address@hidden> -----
Subject: Bug#105529: PATCH
Reply-To: Jeff Licquia <address@hidden>, address@hidden
Resent-From: Jeff Licquia <address@hidden>
Resent-To: address@hidden
Resent-Cc: Timshel Knoll <address@hidden>
Resent-Date: Mon, 16 Jul 2001 22:33:26 GMT
Resent-Message-ID: <address@hidden>
Resent-Sender: address@hidden
X-Debian-PR-Message: report 105529
X-Debian-PR-Package: parted
X-Debian-PR-Keywords: 
Date: Mon, 16 Jul 2001 17:31:24 -0500
From: Jeff Licquia <address@hidden>
To: address@hidden

Found the problem.  There were two things, both related to the
definition of things like uint32_t.

 - Some of the fs_* dirs in libparted (fs_hfs, fs_reiserfs, etc.) had
   source files that included asm/page.h.  Doing so caused the first
   set of uint8_t, etc. errors.

 - In parted/ui.c, the order of header files is a problem.
   Rearranging them (by putting some of those that didn't need
   config.h before config.h) fixed this problem.

I think the problem is related to problems with configure not
detecting that Linux sets __s8 and friends.  Thus, the configure
script #defines them in config.h, which causes some "typedef __s8
uint8_t" type lines in the headers to get really strangely expanded.
The real bug, I suspect, is in autoconf, but the workarounds mentioned
above work.

I have an NMU ready, but will wait at least 24 hours.  The package
builds and works on i386, and can at least read the partition table on
ia64.

Patch:

diff --unified --recursive parted-1.4.15-old/libparted/fs_hfs/hfs.c 
parted-1.4.15/libparted/fs_hfs/hfs.c
--- parted-1.4.15-old/libparted/fs_hfs/hfs.c    Sat Apr  7 16:04:38 2001
+++ parted-1.4.15/libparted/fs_hfs/hfs.c        Mon Jul 16 12:16:33 2001
@@ -34,7 +34,6 @@
 #endif /* ENABLE_NLS */
 
 #include <unistd.h>
-#include <asm/page.h>
 #include <string.h>
 
 #define HFS_SIGNATURE  0x4244
diff --unified --recursive 
parted-1.4.15-old/libparted/fs_linux_swap/linux_swap.c 
parted-1.4.15/libparted/fs_linux_swap/linux_swap.c
--- parted-1.4.15-old/libparted/fs_linux_swap/linux_swap.c      Sat Apr  7 
16:04:38 2001
+++ parted-1.4.15/libparted/fs_linux_swap/linux_swap.c  Mon Jul 16 12:19:14 2001
@@ -38,7 +38,6 @@
 #endif /* ENABLE_NLS */
 
 #include <unistd.h>
-#include <asm/page.h>
 #include <string.h>
 
 #define SWAP_SPECIFIC(fs) ((SwapSpecific*) (fs->type_specific))
diff --unified --recursive parted-1.4.15-old/libparted/fs_ntfs/ntfs.c 
parted-1.4.15/libparted/fs_ntfs/ntfs.c
--- parted-1.4.15-old/libparted/fs_ntfs/ntfs.c  Sat Apr  7 16:04:38 2001
+++ parted-1.4.15/libparted/fs_ntfs/ntfs.c      Mon Jul 16 12:21:12 2001
@@ -34,7 +34,6 @@
 #endif /* ENABLE_NLS */
 
 #include <unistd.h>
-#include <asm/page.h>
 #include <string.h>
 
 #define NTFS_SIGNATURE "NTFS"
diff --unified --recursive parted-1.4.15-old/libparted/fs_reiserfs/reiserfs.c 
parted-1.4.15/libparted/fs_reiserfs/reiserfs.c
--- parted-1.4.15-old/libparted/fs_reiserfs/reiserfs.c  Sat Apr  7 16:04:38 2001
+++ parted-1.4.15/libparted/fs_reiserfs/reiserfs.c      Mon Jul 16 12:21:33 2001
@@ -34,7 +34,6 @@
 #endif /* ENABLE_NLS */
 
 #include <unistd.h>
-#include <asm/page.h>
 #include <string.h>
 
 #define REISERFS_SIGNATURE     "ReIsErFs"
diff --unified --recursive parted-1.4.15-old/parted/ui.c 
parted-1.4.15/parted/ui.c
--- parted-1.4.15-old/parted/ui.c       Mon May 28 16:16:12 2001
+++ parted-1.4.15/parted/ui.c   Mon Jul 16 12:48:32 2001
@@ -19,13 +19,19 @@
 
 #include <parted/parted.h>
 
+#include <ctype.h>
+#include <signal.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+#include <libintl.h>
+#include <locale.h>
+
 #include "../config.h"
 #include "command.h"
 #include "strlist.h"
 #include "ui.h"
 
-#include <libintl.h>
-#include <locale.h>
 #define N_(String) String
 #if ENABLE_NLS
 #  define _(String) dgettext (PACKAGE, String)
@@ -53,12 +59,6 @@
 #endif
 
 #endif /* HAVE_LIBREADLINE */
-
-#include <ctype.h>
-#include <signal.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
 
 char* prog_name = "GNU Parted " VERSION "\n";
 
 


----- End forwarded message -----

-- 
   Timshel Knoll <address@hidden>  for Debian email: <address@hidden>
                Geomatics/Computer Science double degree, RMIT
      Debian GNU/Linux developer, see http://people.debian.org/~timshel/
                For GnuPG public key: finger address@hidden

parted-1.4.15-ia64-fixes.diff
Description: Text document