Re: sun disk label support

[Andrew Clausen]

Ben Collins wrote:
> 
> Well, here is my version. I didn't know anyone else was working on it
> until I checked the archives.

It's a good idea to tell me when you're going to start writing
something.
Some people think differently, but I never understood it...

> This does support Whole Disk to a point.

What needs to change?  BTW, rather than checking id == WHOLE_DISK_ID,
can't you check if it starts at 0 and finishes at ~dev->length ?

> My todo list is to add an fs_ufs/ so sun partitions can be recognized.

> Also I need to add support for the flags (unmountable).

Sounds good.

> My only concern is when using "mkfs" or "mkpartfs", the disk type is
> converted to "loop" and one bug partition is created. Is this a bug in
> my code, or parted?

Errr.  It's "an issue", should I say.

The problem is, Parted can operate on file systems directly (i.e.
partitions).  For example:

        # parted /dev/hda5

If a file system is detected, then the magic "loop" disk label is
used.

You can fix your problem by registering sun support AFTER loop,
so it is probed first.

Andrew Clausen