Re: [PATCH] Do not reset color definitions

[Thomas Dickey]

On Fri, Dec 16, 2016 at 03:25:02AM +0500, Mihail Konev wrote:
> They could be set by user.
> ---
> Or is it better to use terminfo() == "linux" check,

no.

> with NCURSES_NO_COLORDEF_RESET envvar?

perhaps (will think about this - there are several aspects to consider)
 
>  ncurses/base/lib_color.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)

no.
 
> diff --git a/ncurses/base/lib_color.c b/ncurses/base/lib_color.c
> index 9b4d2b8f8d85..6ab991148afa 100644
> --- a/ncurses/base/lib_color.c
> +++ b/ncurses/base/lib_color.c
> @@ -272,9 +272,7 @@ reset_color_pair(NCURSES_SP_DCL0)
>  }
>  
>  /*
> - * Reset color pairs and definitions.  Actually we do both more to 
> accommodate
> - * badly-written terminal descriptions than for the relatively rare case 
> where
> - * someone has changed the color definitions.
> + * Reset color pairs.
>   */
>  NCURSES_EXPORT(bool)
>  NCURSES_SP_NAME(_nc_reset_colors) (NCURSES_SP_DCL0)
> @@ -287,14 +285,6 @@ NCURSES_SP_NAME(_nc_reset_colors) (NCURSES_SP_DCL0)
>      if (reset_color_pair(NCURSES_SP_ARG))
>       result = TRUE;
>  
> -#ifdef USE_TERM_DRIVER
> -    result = CallDriver(SP_PARM, td_rescolors);
> -#else
> -    if (orig_colors != 0) {
> -     NCURSES_PUTP2("orig_colors", orig_colors);
> -     result = TRUE;
> -    }
> -#endif
>      returnBool(result);
>  }
>  
> -- 
> 2.9.2
> 
> 
> _______________________________________________
> Bug-ncurses mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/bug-ncurses

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature