Re: Unlink failure on abort

[Eli Zaretskii]

> From: Orgad Shaneh <address@hidden>
> Date: Sun, 18 Jun 2017 08:02:21 +0300
> Cc: address@hidden, Alexey Pavlov <address@hidden>
> 
>  Please try the same, but with Sleep calls using 10 or even 5 msec (and
>  enlarging the loop count if necessary). I'd be interested to see the
>  statistics of the count after which the unlink call succeeds in your
>  cases.
> 
>  Thanks.
> 
> On my machine it also doesn't reproduce every time, but I can reproduce it.
> 
> I used Sleep(5), and had count of 2 (I had the same with Sleep(50)).

That's strange.  How many cores do you have on that system?

> I think the problem is that reap_children() is called after 
> delete_child_targets, so the child jobs can still run
> while make is trying to delete.
> 
> Maybe delete_targets should become part of reap_children (it cannot be called 
> after reap, because at this
> point you don't have the target info anymore).
> 
> What do you say?

I will let Paul to chime in and comment about that.  Failing that, I
will push your changes after trying them on my box here.

Thanks.