[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Refactor and merge child_execute_job() code, new attempt
From: |
Paul Smith |
Subject: |
Re: [PATCH] Refactor and merge child_execute_job() code, new attempt |
Date: |
Sun, 09 Mar 2014 18:53:21 -0400 |
On Wed, 2014-03-05 at 22:04 +0400, Pavel Fedin wrote:
> Hello, Paul! Sorry for so long delay, i'm really quite busy, however i
> have found some time to get back to this. Please review the new
> version.
I like this patch; it looks like a good improvement! It works fine for
me on UNIX systems.
Only one comment:
> - /* undo CLOSE_ON_EXEC() after the child process has been started */
> + /* undo FD_CLOEXEC after the child process has been started */
I think this change should be reverted, since we decided to keep the
CLOSE_ON_EXEC() macro.
Thanks Pavel!