bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of


From: Eli Zaretskii
Subject: Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time
Date: Fri, 31 Jan 2014 16:55:16 +0200

> Date: Fri, 31 Jan 2014 22:15:56 +0900
> From: Mike Hommey <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden,
>       address@hidden
> 
> On Fri, Jan 31, 2014 at 11:37:47AM +0200, Eli Zaretskii wrote:
> > > Date: Fri, 31 Jan 2014 09:14:32 +0000
> > > From: Mike Hommey <address@hidden>
> > > 
> > > This is a different approach to the problem, as suggested by Paul: this
> > > triggers batch mode shell when there are double quotes in the recipe.
> > 
> > This cannot be automatic, as we have deliberately made the double
> > quotes not special for Windows shells.
> 
> You mean cmd.exe? The patch only uses batch mode shell when there are
> double quotes *and* the shell is unixy (so, not cmd.exe)

That's better, but still too subtly to be the default, I think.
Having some essentially random character trigger very different
behavior is bad mojo for a program in general.

> > So please make this
> > conditional on some Make option (sorry, I didn't yet have time to look
> > at the patch).
> 
> An option as command line argument, or as a special target as the
> original patch did?

The former, as Paul objected to the latter.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]